diff mbox

[FFmpeg-devel] avcodec/aacdec_fixed: Fix integer overflow in apply_independent_coupling_fixed()

Message ID 20180331194423.2976-1-michael@niedermayer.cc
State Accepted
Commit 197a4e8feed45b2e5868760240e83636818f32a9
Headers show

Commit Message

Michael Niedermayer March 31, 2018, 7:44 p.m. UTC
I was not able to reproduce this, this fix is based on just the fuzzer log.
Fixes: 4959/clusterfuzz-testcase-minimized-6035350934781952

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavcodec/aacdec_fixed.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Niedermayer April 2, 2018, 9:26 p.m. UTC | #1
On Sat, Mar 31, 2018 at 09:44:23PM +0200, Michael Niedermayer wrote:
> I was not able to reproduce this, this fix is based on just the fuzzer log.
> Fixes: 4959/clusterfuzz-testcase-minimized-6035350934781952
> 
> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavcodec/aacdec_fixed.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

will apply


[...]
diff mbox

Patch

diff --git a/libavcodec/aacdec_fixed.c b/libavcodec/aacdec_fixed.c
index f96999efb4..5c3613e06c 100644
--- a/libavcodec/aacdec_fixed.c
+++ b/libavcodec/aacdec_fixed.c
@@ -417,7 +417,7 @@  static void apply_independent_coupling_fixed(AACContext *ac,
     int i, c, shift, round, tmp;
     const int gain = cce->coup.gain[index][0];
     const int *src = cce->ch[0].ret;
-    int *dest = target->ret;
+    unsigned int *dest = target->ret;
     const int len = 1024 << (ac->oc[1].m4ac.sbr == 1);
 
     c = cce_scale_fixed[gain & 7];