diff mbox series

[FFmpeg-devel,20/26] avformat/subviewerdec: Fix memleak upon read header failure

Message ID 20200614223656.21338-20-andreas.rheinhardt@gmail.com
State Accepted
Commit a708f652737eba08607df84394ca4bec6b458736
Headers show
Series [FFmpeg-devel,01/26] avformat/matroskadec: Move AVBufferRef instead of copying, fix memleak | expand


Context Check Description
andriy/default pending
andriy/make success Make finished
andriy/make_fate success Make fate finished

Commit Message

Andreas Rheinhardt June 14, 2020, 10:36 p.m. UTC
The already parsed subtitles (contained in an FFDemuxSubtitlesQueue)
would leak if an error happened upon reading a subsequent subtitle.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
 libavformat/subviewerdec.c | 2 ++
 1 file changed, 2 insertions(+)
diff mbox series


diff --git a/libavformat/subviewerdec.c b/libavformat/subviewerdec.c
index 83378eab5f..fdca3a4820 100644
--- a/libavformat/subviewerdec.c
+++ b/libavformat/subviewerdec.c
@@ -172,6 +172,8 @@  static int subviewer_read_header(AVFormatContext *s)
     ff_subtitles_queue_finalize(s, &subviewer->q);
+    if (res < 0)
+        ff_subtitles_queue_clean(&subviewer->q);
     av_bprint_finalize(&header, NULL);
     return res;