diff mbox series

[FFmpeg-devel,4/7] avcodec/h261dec: Remove parse_context cruft

Message ID 20201225154724.287465-4-andreas.rheinhardt@gmail.com
State Accepted
Commit 7f1207cb79e79785ac837a9cd9f9ab6f0ba3462f
Headers show
Series [FFmpeg-devel,1/7] avcodec/mpeg12dec: Remove update_thread_context | expand

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

Andreas Rheinhardt Dec. 25, 2020, 3:47 p.m. UTC 
The H.261 decoder doesn't use the ParseContext of its
MpegEncContext since e7316976650b429345da619c3acff38004aaf6b8.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
---
Does actually anybody use the AV_CODEC_FLAG_TRUNCATED (MpegEncContext
contains a ParseContext because of this flag)?

 libavcodec/h261dec.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Anton Khirnov March 8, 2021, 10 a.m. UTC | #1 
Quoting Andreas Rheinhardt (2020-12-25 16:47:21)
> The H.261 decoder doesn't use the ParseContext of its
> MpegEncContext since e7316976650b429345da619c3acff38004aaf6b8.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
> ---

Looks good, please push.

> Does actually anybody use the AV_CODEC_FLAG_TRUNCATED (MpegEncContext
> contains a ParseContext because of this flag)?

I will send a patch to deprecate it shortly.
diff mbox series

Patch

diff --git a/libavcodec/h261dec.c b/libavcodec/h261dec.c
index 8a49e7d894..4f1f22b279 100644
--- a/libavcodec/h261dec.c
+++ b/libavcodec/h261dec.c
@@ -613,10 +613,7 @@  retry:
     }
 
     if (s->width != avctx->coded_width || s->height != avctx->coded_height) {
-        ParseContext pc = s->parse_context; // FIXME move this demuxing hack to libavformat
-        s->parse_context.buffer = 0;
         ff_mpv_common_end(s);
-        s->parse_context = pc;
     }
 
     if (!s->context_initialized) {