diff mbox series

[FFmpeg-devel,04/18] avformat/matroskadec: Reuse AVFormatInternal.parse_pkt

Message ID 20210319055904.2264501-4-andreas.rheinhardt@gmail.com
State Accepted
Commit a4d036965dac42e7a7b50c6038c928d008655282
Headers show
Series [FFmpeg-devel,01/18] libavformat/utils: Fix indentation | expand


Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

Andreas Rheinhardt March 19, 2021, 5:58 a.m. UTC
Before 8d78e90a6ba96646f7f25aff6ca3e12e71cec164 the Matroska demuxer
used stack packets to hold temporary packets; now it uses a temporary
packet allocated by the Matroska demuxer. Yet because it used stack
packets the code has always properly reset the packet on error, while
on success these temporary packets were put into a packet list via
avpriv_packet_list_put(), which already resets the source packet.
This means that this code is compatible with just reusing
AVFormatInternal.parse_pkt (which is unused while one is in the
demuxer's read_packet() function). Compared to before 8d78e90a6
this no longer wastes one initialization per AVPacket read
(the resetting of the stack packet performed by av_packet_move_ref()
in avpriv_packet_list_put() was for naught).

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
 libavformat/internal.h    | 3 +++
 libavformat/matroskadec.c | 8 +++-----
 2 files changed, 6 insertions(+), 5 deletions(-)
diff mbox series


diff --git a/libavformat/internal.h b/libavformat/internal.h
index a810d51bba..c730332031 100644
--- a/libavformat/internal.h
+++ b/libavformat/internal.h
@@ -98,6 +98,9 @@  struct AVFormatInternal {
      * for short periods that are guaranteed not to overlap
      * with calls to av_read_frame() (or ff_read_packet())
      * or with each other.
+     * It may be used by demuxers as a replacement for
+     * stack packets (unless they call one of the aforementioned
+     * functions with their own AVFormatContext).
      * Every user has to ensure that this packet is blank
      * after using it.
diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c
index 9acfdf5b32..1dc188c946 100644
--- a/libavformat/matroskadec.c
+++ b/libavformat/matroskadec.c
@@ -381,6 +381,8 @@  typedef struct MatroskaDemuxContext {
     /* byte position of the segment inside the stream */
     int64_t segment_start;
+    /* This packet coincides with AVFormatInternal.parse_pkt
+     * and is not owned by us. */
     AVPacket *pkt;
     /* the packet queue */
@@ -2945,9 +2947,7 @@  static int matroska_read_header(AVFormatContext *s)
     ebml_free(ebml_syntax, &ebml);
-    matroska->pkt = av_packet_alloc();
-    if (!matroska->pkt)
-        return AVERROR(ENOMEM);
+    matroska->pkt = s->internal->parse_pkt;
     /* The next thing is a segment. */
     pos = avio_tell(matroska->ctx->pb);
@@ -3528,7 +3528,6 @@  static int matroska_parse_frame(MatroskaDemuxContext *matroska,
     if (!pkt_size && !additional_size)
         goto no_output;
-    av_packet_unref(pkt);
     if (!buf)
         pkt->buf = av_buffer_create(pkt_data, pkt_size + AV_INPUT_BUFFER_PADDING_SIZE,
                                     NULL, NULL, 0);
@@ -3902,7 +3901,6 @@  static int matroska_read_close(AVFormatContext *s)
     int n;
-    av_packet_free(&matroska->pkt);
     for (n = 0; n < matroska->tracks.nb_elem; n++)
         if (tracks[n].type == MATROSKA_TRACK_TYPE_AUDIO)