diff mbox series

[FFmpeg-devel,08/18] avformat/ipmovie: Remove redundant av_packet_unref()

Message ID 20210319055904.2264501-8-andreas.rheinhardt@gmail.com
State Accepted
Commit da9eed79b9255c0b26110d731880a531fc7b22ef
Headers show
Series [FFmpeg-devel,01/18] libavformat/utils: Fix indentation | expand

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

Andreas Rheinhardt March 19, 2021, 5:58 a.m. UTC 
When one of these errors happens during ipmovie_read_packet(),
an error is returned and the packet is cleaned up generically.
And since 712d3ac539f30239b764d8621829dc9dc913da61 the same happens
in ipmovie_read_header().

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
---
 libavformat/ipmovie.c | 3 ---
 1 file changed, 3 deletions(-)
diff mbox series

Patch

diff --git a/libavformat/ipmovie.c b/libavformat/ipmovie.c
index 3234d591da..26886d9592 100644
--- a/libavformat/ipmovie.c
+++ b/libavformat/ipmovie.c
@@ -194,7 +194,6 @@  static int load_ipmovie_packet(IPMVEContext *s, AVIOContext *pb,
 
         if (avio_read(pb, pkt->data + 8, s->video_chunk_size) !=
             s->video_chunk_size) {
-            av_packet_unref(pkt);
             return CHUNK_EOF;
         }
 
@@ -205,7 +204,6 @@  static int load_ipmovie_packet(IPMVEContext *s, AVIOContext *pb,
 
             if (avio_read(pb, pkt->data + 8 + s->video_chunk_size,
                 s->decode_map_chunk_size) != s->decode_map_chunk_size) {
-                av_packet_unref(pkt);
                 return CHUNK_EOF;
             }
         }
@@ -217,7 +215,6 @@  static int load_ipmovie_packet(IPMVEContext *s, AVIOContext *pb,
 
             if (avio_read(pb, pkt->data + 8 + s->video_chunk_size + s->decode_map_chunk_size,
                 s->skip_map_chunk_size) != s->skip_map_chunk_size) {
-                av_packet_unref(pkt);
                 return CHUNK_EOF;
             }
         }