diff mbox series

[FFmpeg-devel,1/3] avcodec/svq1enc: Do not print debug RD value before it has been computed

Message ID 20210530180255.23554-1-michael@niedermayer.cc
State Accepted
Commit c297f7e57a223da9f0d350e30456d60c8c87f902
Headers show
Series [FFmpeg-devel,1/3] avcodec/svq1enc: Do not print debug RD value before it has been computed | expand

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

Michael Niedermayer May 30, 2021, 6:02 p.m. UTC 
Avoids floating point division by 0

Fixes: Ticket8191

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavcodec/svq1enc.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Comments

Michael Niedermayer June 2, 2021, 3:34 p.m. UTC | #1 
On Sun, May 30, 2021 at 08:02:53PM +0200, Michael Niedermayer wrote:
> Avoids floating point division by 0
> 
> Fixes: Ticket8191
> 
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavcodec/svq1enc.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

will apply

[...]
diff mbox series

Patch

diff --git a/libavcodec/svq1enc.c b/libavcodec/svq1enc.c
index 09fa15a3a2..91a208180b 100644
--- a/libavcodec/svq1enc.c
+++ b/libavcodec/svq1enc.c
@@ -486,9 +486,10 @@  static av_cold int svq1_encode_end(AVCodecContext *avctx)
     SVQ1EncContext *const s = avctx->priv_data;
     int i;
 
-    av_log(avctx, AV_LOG_DEBUG, "RD: %f\n",
-           s->rd_total / (double)(avctx->width * avctx->height *
-                                  avctx->frame_number));
+    if (avctx->frame_number)
+        av_log(avctx, AV_LOG_DEBUG, "RD: %f\n",
+               s->rd_total / (double)(avctx->width * avctx->height *
+                                      avctx->frame_number));
 
     s->m.mb_type = NULL;
     ff_mpv_common_end(&s->m);