diff mbox series

[FFmpeg-devel,v5] avcodec/libx264: add warning log when droping picture at 'h264_select_output_frame'

Message ID 20211230061145.20864-1-zozobreak@163.com
State New
Headers show
Series [FFmpeg-devel,v5] avcodec/libx264: add warning log when droping picture at 'h264_select_output_frame' | expand

Checks

Context Check Description
andriy/commit_msg_x86 warning Please wrap lines in the body of the commit message between 60 and 72 characters.
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished
andriy/commit_msg_ppc warning Please wrap lines in the body of the commit message between 60 and 72 characters.
andriy/make_ppc success Make finished
andriy/make_fate_ppc fail Make fate failed

Commit Message

zozobreak@163.com Dec. 30, 2021, 6:11 a.m. UTC
since there is only debug log 'no picture ooo' when droping a picture,
I spent much time to troubleshooting a wrong sps 'num_reorder_frames' param changed by webrtc's 'ParseAndRewriteSps',
FFmpeg keeped silence about this error, so a warning log is much helpfull about this.

Signed-off-by: zourenyi <zozobreak@163.com>
---
 libavcodec/h264_slice.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

Comments

zhilizhao(赵志立) Dec. 30, 2021, 6:56 a.m. UTC | #1
> On Dec 30, 2021, at 2:11 PM, zourenyi <zozobreak@163.com> wrote:
> 
> since there is only debug log 'no picture ooo' when droping a picture,
> I spent much time to troubleshooting a wrong sps 'num_reorder_frames' param changed by webrtc's 'ParseAndRewriteSps',
> FFmpeg keeped silence about this error, so a warning log is much helpfull about this.
> 
> Signed-off-by: zourenyi <zozobreak@163.com>
> ---
> libavcodec/h264_slice.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c
> index c21004df97..f347d8ee1a 100644
> --- a/libavcodec/h264_slice.c
> +++ b/libavcodec/h264_slice.c
> @@ -1533,7 +1533,13 @@ static int h264_select_output_frame(H264Context *h)
>             }
>         }
>     } else {
> -        av_log(h->avctx, AV_LOG_DEBUG, "no picture %s\n", out_of_order ? "ooo" : "");
> +        if (out_of_order) {
> +            av_log(h->avctx, AV_LOG_WARNING,
> +                   "drop picture(%c, %d/%" PRId64 ") because out of order\n",
> +                   av_get_picture_type_char(out->f->pict_type), out->poc, out->f->pts);
> +        } else {
> +            av_log(h->avctx, AV_LOG_DEBUG, "no picture\n");
> +        }
>     }

The patch is about decoding, has nothing to do with libx264.
Please fix the commit subject.

> 
>     return 0;
> -- 
> 2.34.1
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox series

Patch

diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c
index c21004df97..f347d8ee1a 100644
--- a/libavcodec/h264_slice.c
+++ b/libavcodec/h264_slice.c
@@ -1533,7 +1533,13 @@  static int h264_select_output_frame(H264Context *h)
             }
         }
     } else {
-        av_log(h->avctx, AV_LOG_DEBUG, "no picture %s\n", out_of_order ? "ooo" : "");
+        if (out_of_order) {
+            av_log(h->avctx, AV_LOG_WARNING,
+                   "drop picture(%c, %d/%" PRId64 ") because out of order\n",
+                   av_get_picture_type_char(out->f->pict_type), out->poc, out->f->pts);
+        } else {
+            av_log(h->avctx, AV_LOG_DEBUG, "no picture\n");
+        }
     }
 
     return 0;