diff mbox series

[FFmpeg-devel,5/5] Fix review feedback

Message ID 20220131135116.14035-6-markg85@gmail.com
State New
Headers show
Series Add IPFS and IPNS protocol support | expand

Checks

Context Check Description
andriy/commit_msg_x86 warning The first line of the commit message must start with a context terminated by a colon and a space, for example "lavu/opt: " or "doc: ".
andriy/commit_msg_aarch64_jetson warning The first line of the commit message must start with a context terminated by a colon and a space, for example "lavu/opt: " or "doc: ".
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished
andriy/commit_msg_ppc warning The first line of the commit message must start with a context terminated by a colon and a space, for example "lavu/opt: " or "doc: ".
andriy/make_ppc success Make finished
andriy/make_fate_ppc success Make fate finished
andriy/make_aarch64_jetson success Make finished
andriy/make_fate_aarch64_jetson success Make fate finished
andriy/commit_msg_armv7_RPi4 warning The first line of the commit message must start with a context terminated by a colon and a space, for example "lavu/opt: " or "doc: ".
andriy/make_armv7_RPi4 success Make finished
andriy/make_fate_armv7_RPi4 success Make fate finished

Commit Message

Mark Gaiser Jan. 31, 2022, 1:51 p.m. UTC 
Little bit of consistency in punctuations.

Signed-off-by: Mark Gaiser <markg85@gmail.com>
---
 libavformat/ipfs.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Michael Niedermayer Jan. 31, 2022, 3:46 p.m. UTC | #1 
On Mon, Jan 31, 2022 at 02:51:16PM +0100, Mark Gaiser wrote:
> Little bit of consistency in punctuations.
> 
> Signed-off-by: Mark Gaiser <markg85@gmail.com>
> ---
>  libavformat/ipfs.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Review fixes should be integrated into the patches when they are not applied
yet. not done as a seperate patch on top

also there are some tabs and trailing whitespace in the earlier patches
which should be fixed too

thx


[...]
Mark Gaiser Jan. 31, 2022, 4:33 p.m. UTC | #2 
On Mon, Jan 31, 2022 at 4:46 PM Michael Niedermayer <michael@niedermayer.cc>
wrote:

> On Mon, Jan 31, 2022 at 02:51:16PM +0100, Mark Gaiser wrote:
> > Little bit of consistency in punctuations.
> >
> > Signed-off-by: Mark Gaiser <markg85@gmail.com>
> > ---
> >  libavformat/ipfs.c | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
>
> Review fixes should be integrated into the patches when they are not
> applied
> yet. not done as a seperate patch on top
>
> also there are some tabs and trailing whitespace in the earlier patches
> which should be fixed too
>
> Thank you, Michael, that's much appreciated! I will fix those in V2.


> thx
>
>
> [...]
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Into a blind darkness they enter who follow after the Ignorance,
> they as if into a greater darkness enter who devote themselves
> to the Knowledge alone. -- Isha Upanishad
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
diff mbox series

Patch

diff --git a/libavformat/ipfs.c b/libavformat/ipfs.c
index 8f6f91d85d..1644c74eac 100644
--- a/libavformat/ipfs.c
+++ b/libavformat/ipfs.c
@@ -46,7 +46,7 @@  typedef struct Context {
 
 // A best-effort way to find the IPFS gateway.
 // Only the most appropiate gateway is set. It's not actually requested (http call) to prevent
-// potential slowdown in startup. A potential timeout is handled by the HTTP protocol.
+// a potential slowdown in startup. A potential timeout is handled by the HTTP protocol.
 //
 // When done and the return value is 1, a potential IPFS Gateway is set in the gateway
 // variable in the inner URLContext.
@@ -68,7 +68,7 @@  static int populate_ipfs_gateway(URLContext *h)
         return 1;
     }
 
-    // Test $IPFS_GATEWAY
+    // Test $IPFS_GATEWAY.
     c->gateway = getenv("IPFS_GATEWAY");
     if (c->gateway) {
         return 1;
@@ -82,7 +82,7 @@  static int populate_ipfs_gateway(URLContext *h)
     if (!ipfs_full_data_folder) {
         av_log(h, AV_LOG_DEBUG, "$IPFS_PATH is empty.\n");
 
-        // Try via the home folder
+        // Try via the home folder.
         home_folder = getenv("HOME");
         ipfs_full_data_folder = malloc(strlen(home_folder) + strlen(ipfs_data_folder) + 1);
         strcpy(ipfs_full_data_folder, home_folder);
@@ -117,7 +117,7 @@  static int populate_ipfs_gateway(URLContext *h)
         return -1;
     }
 
-    // Get the contents of the gateway file
+    // Get the contents of the gateway file.
     gateway_file = av_fopen_utf8(ipfs_gateway_file, "r");
     if (!gateway_file) {
         av_log(h, AV_LOG_ERROR, "Unable to open the IPFS gateway file (full uri: %s).\n", ipfs_gateway_file);
@@ -132,7 +132,7 @@  static int populate_ipfs_gateway(URLContext *h)
         return -1;
     }
 
-    // Copy the gateway url into c->gateway
+    // Copy the gateway url into c->gateway.
     c->gateway = malloc(strlen(gateway_file_data) + 1);
     strcpy(c->gateway, gateway_file_data);
     if (c->gateway) {
@@ -194,7 +194,7 @@  static int ipfs_open(URLContext *h, const char *uri, int flags, AVDictionary **o
         goto err;
     }
 
-    // If we have IPNS, update the protocol
+    // If we have IPNS, update the protocol.
     if (is_ipns) {
         protocol_path_suffix = "ipns/";
     }