diff mbox series

[FFmpeg-devel,4/4] doc/developer.texi: refine the "contributing code" section

Message ID 20221114091309.15755-4-anton@khirnov.net
State Accepted
Commit 6a3e174ad1921ba6aec473a2224c71610de3329b
Headers show
Series [FFmpeg-devel,1/4] doc/developer.texi: improve the introductory text | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Anton Khirnov Nov. 14, 2022, 9:13 a.m. UTC 
Drop the reference to directly committing code, because
- it is highly discouraged and very rarely done these days
- there is no good reason NOT to submit patches for review

Add a link to the development policy chapter.
---
 doc/developer.texi | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)
diff mbox series

Patch

diff --git a/doc/developer.texi b/doc/developer.texi
index 2e050edc6a..cf918ac6b1 100644
--- a/doc/developer.texi
+++ b/doc/developer.texi
@@ -46,15 +46,10 @@  consult @url{https://ffmpeg.org/legal.html}.
 
 @section Contributing code
 
-There are 2 ways by which code gets into FFmpeg:
-@itemize @bullet
-@item Submitting patches to the ffmpeg-devel mailing list.
-      See @ref{Submitting patches} for details.
-@item Directly committing changes to the main tree.
-@end itemize
-
-Whichever way, changes should be reviewed by the maintainer of the code
-before they are committed. And they should follow the @ref{Coding Rules}.
+All proposed code changes should be submitted for review to
+@url{mailto:ffmpeg-devel@@ffmpeg.org, the development mailing list}, as
+described in more detail in the @ref{Submitting patches} chapter. The code
+should comply with the @ref{Development Policy} and follow the @ref{Coding Rules}.
 The developer making the commit and the author are responsible for their changes
 and should try to fix issues their commit causes.
 
@@ -267,6 +262,7 @@  For Emacs, add these roughly equivalent lines to your @file{.emacs.d/init.el}:
 (setq c-default-style "ffmpeg")
 @end lisp
 
+@anchor{Development Policy}
 @chapter Development Policy
 
 @section Patches/Committing