| Message ID | 20240131193717.407384-1-leo.izen@gmail.com |
|---|---|
| State | Accepted |
| Commit | eb4df2709ec41923b598650051c39b1eda392c8b |
| Headers | show |
| Series | [FFmpeg-devel] avcodec/tiff: pass arguments to bytestream2_seek in the right order | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
On 1/31/24 14:37, Leo Izen wrote: > The function signature for bytestream2_seek is (gb, offset, whence); > Before this patch, the code passed (gb, SEEK_SET, offset), which is > incorrect. > > Siged-off-by: Leo Izen <leo.izen@gmail.com> > --- > libavcodec/tiff.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c > index adb49e4525..3ce441aa2c 100644 > --- a/libavcodec/tiff.c > +++ b/libavcodec/tiff.c > @@ -1701,7 +1701,7 @@ static int tiff_decode_tag(TiffContext *s, AVFrame *frame) > break; > case TIFF_ICC_PROFILE: > gb_temp = s->gb; > - bytestream2_seek(&gb_temp, SEEK_SET, off); > + bytestream2_seek(&gb_temp, off, SEEK_SET); > > if (bytestream2_get_bytes_left(&gb_temp) < count) > return AVERROR_INVALIDDATA; Will apply soon. - Leo Izen (Traneptora)
diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index adb49e4525..3ce441aa2c 100644 --- a/libavcodec/tiff.c +++ b/libavcodec/tiff.c @@ -1701,7 +1701,7 @@ static int tiff_decode_tag(TiffContext *s, AVFrame *frame) break; case TIFF_ICC_PROFILE: gb_temp = s->gb; - bytestream2_seek(&gb_temp, SEEK_SET, off); + bytestream2_seek(&gb_temp, off, SEEK_SET); if (bytestream2_get_bytes_left(&gb_temp) < count) return AVERROR_INVALIDDATA;