diff mbox series

[FFmpeg-devel] libavformat/hlsenc: fix a memory leak in libavformat/hlsenc.c

Message ID 20240413063529.2270832-1-lumingyindetect@163.com
State New
Headers show
Series [FFmpeg-devel] libavformat/hlsenc: fix a memory leak in libavformat/hlsenc.c | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

LuMingYin April 13, 2024, 6:35 a.m. UTC 
In the function 'hls_write_trailer' in the file '/FFmpeg/libavformat/hlsenc.c', the variable named 'options' allocates a block of dynamic memory in the 'av_dict_set' function, which is not freed on error paths.

Signed-off-by: LuMingYin <lumingyindetect@163.com>
---
 libavformat/hlsenc.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Steven Liu April 15, 2024, 12:25 p.m. UTC | #1 
LuMingYin <lumingyindetect@163.com> 于2024年4月13日周六 14:35写道：
>
> In the function 'hls_write_trailer' in the file '/FFmpeg/libavformat/hlsenc.c', the variable named 'options' allocates a block of dynamic memory in the 'av_dict_set' function, which is not freed on error paths.
>
> Signed-off-by: LuMingYin <lumingyindetect@163.com>
> ---
>  libavformat/hlsenc.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
> index bde7230036..0e2843c6bc 100644
> --- a/libavformat/hlsenc.c
> +++ b/libavformat/hlsenc.c
> @@ -2757,6 +2757,7 @@ static int hls_write_trailer(struct AVFormatContext *s)
>              filename = av_asprintf("%s", oc->url);
>          }
>          if (!filename) {
> +            av_dict_free(&options);
>              av_freep(&old_filename);
>              return AVERROR(ENOMEM);
>          }
> --
> 2.25.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

LGTM



Thanks
Steven
diff mbox series

Patch

diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
index bde7230036..0e2843c6bc 100644
--- a/libavformat/hlsenc.c
+++ b/libavformat/hlsenc.c
@@ -2757,6 +2757,7 @@  static int hls_write_trailer(struct AVFormatContext *s)
             filename = av_asprintf("%s", oc->url);
         }
         if (!filename) {
+            av_dict_free(&options);
             av_freep(&old_filename);
             return AVERROR(ENOMEM);
         }