diff mbox series

[FFmpeg-devel] doc/examples: Always open files as "binary", not "text"

Message ID CAB0OVGo5j_oDtde-GUkGaMO-JkRjH2ptk0cgLq_CoQsRAopM0A@mail.gmail.com
State Accepted
Commit 68f637b6f94d25f45eee2e9320e0057a548b92e0
Headers show
Series [FFmpeg-devel] doc/examples: Always open files as "binary", not "text" | expand

Commit Message

Carl Eugen Hoyos June 24, 2020, 10:04 p.m. UTC 
Hi!

Attached patch fixes ticket #8638 and the only other occurrence of
fopen() without b in doc/examples.

Please comment, Carl Eugen
Subject: [PATCH] doc/examples: Always open files as "binary", not "text".

Fixes ticket #8638.
---
 doc/examples/decode_video.c | 2 +-
 doc/examples/hw_decode.c    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Carl Eugen Hoyos Aug. 25, 2020, 4:56 p.m. UTC | #1 
Am Do., 25. Juni 2020 um 00:04 Uhr schrieb Carl Eugen Hoyos
<ceffmpeg@gmail.com>:

> Attached patch fixes ticket #8638 and the only other occurrence of
> fopen() without b in doc/examples.

Patch applied.

Carl Eugen
diff mbox series

Patch

diff --git a/doc/examples/decode_video.c b/doc/examples/decode_video.c
index 169188a4b9..18ee90a6c0 100644
--- a/doc/examples/decode_video.c
+++ b/doc/examples/decode_video.c
@@ -41,7 +41,7 @@  static void pgm_save(unsigned char *buf, int wrap, int xsize, int ysize,
     FILE *f;
     int i;
 
-    f = fopen(filename,"w");
+    f = fopen(filename,"wb");
     fprintf(f, "P5\n%d %d\n%d\n", xsize, ysize, 255);
     for (i = 0; i < ysize; i++)
         fwrite(buf + i * wrap, 1, xsize, f);
diff --git a/doc/examples/hw_decode.c b/doc/examples/hw_decode.c
index f3286f472d..71be6e6709 100644
--- a/doc/examples/hw_decode.c
+++ b/doc/examples/hw_decode.c
@@ -223,7 +223,7 @@  int main(int argc, char *argv[])
     }
 
     /* open the file to dump raw data */
-    output_file = fopen(argv[3], "w+");
+    output_file = fopen(argv[3], "w+b");
 
     /* actual decoding and dump the raw data */
     while (ret >= 0) {