diff mbox

[FFmpeg-devel] lavc/libx264: Cast bit_rate to int64_t to avoid an integer overflow

Message ID CAB0OVGou-HO30zkonXMMGFfDyq0wRa5Q4abZrz0PKyMK7g6eTQ@mail.gmail.com
State Accepted
Headers show

Commit Message

Carl Eugen Hoyos Aug. 10, 2019, 3:35 p.m. UTC 
Am Sa., 10. Aug. 2019 um 17:12 Uhr schrieb Carl Eugen Hoyos
<ceffmpeg@gmail.com>:
>
> Hi!
>
> Attached patch really fixes ticket #8071 for me.

Simpler variant attached.

Carl Eugen

Comments

Carl Eugen Hoyos Aug. 10, 2019, 9:38 p.m. UTC | #1 
Am Sa., 10. Aug. 2019 um 17:35 Uhr schrieb Carl Eugen Hoyos
<ceffmpeg@gmail.com>:
>
> Am Sa., 10. Aug. 2019 um 17:12 Uhr schrieb Carl Eugen Hoyos
> <ceffmpeg@gmail.com>:
> >
> > Hi!
> >
> > Attached patch really fixes ticket #8071 for me.
>
> Simpler variant attached.

Patch applied.

Carl Eugen
diff mbox

Patch

From e94234fb683b30518d96b1a36aba9e27c4cf9f1b Mon Sep 17 00:00:00 2001
From: Carl Eugen Hoyos <ceffmpeg@gmail.com>
Date: Sat, 10 Aug 2019 17:10:58 +0200
Subject: [PATCH] lavc/libx264: Cast bit_rate to int64_t to avoid an integer
 overflow.

Fixes ticket #8071.
---
 libavcodec/libx264.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c
index dc4b4b100d..772fc614ac 100644
--- a/libavcodec/libx264.c
+++ b/libavcodec/libx264.c
@@ -898,7 +898,7 @@  FF_ENABLE_DEPRECATION_WARNINGS
     if (avctx->max_b_frames < 0)
         avctx->max_b_frames = 0;
 
-    avctx->bit_rate = x4->params.rc.i_bitrate*1000;
+    avctx->bit_rate = x4->params.rc.i_bitrate*1000LL;
 
     x4->enc = x264_encoder_open(&x4->params);
     if (!x4->enc)
-- 
2.22.0