diff mbox series

[FFmpeg-devel,1/6] avcodec/mpegvideo: Ignore skip_idct for encoders

Message ID GV1P250MB0737DB7E1DA91101E51ECD208F299@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM
State Accepted
Commit cab876f5f477d54b0f6faccf036e3cbb536b1a60
Headers show
Series [FFmpeg-devel,1/6] avcodec/mpegvideo: Ignore skip_idct for encoders | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Andreas Rheinhardt Oct. 17, 2022, 1:33 a.m. UTC 
It is documented to be unused for encoders.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavcodec/mpegvideo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andreas Rheinhardt Oct. 19, 2022, 12:12 p.m. UTC | #1 
Andreas Rheinhardt:
> It is documented to be unused for encoders.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavcodec/mpegvideo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c
> index 5095149eaa..448b65bb96 100644
> --- a/libavcodec/mpegvideo.c
> +++ b/libavcodec/mpegvideo.c
> @@ -1413,7 +1413,6 @@ void mpv_reconstruct_mb_internal(MpegEncContext *s, int16_t block[12][64],
>                          ff_mpv_motion(s, dest_y, dest_cb, dest_cr, 1, s->next_picture.f->data, op_pix, op_qpix);
>                      }
>                  }
> -            }
>  
>              /* skip dequant / idct if we are really late ;) */
>              if(s->avctx->skip_idct){
> @@ -1422,6 +1421,7 @@ void mpv_reconstruct_mb_internal(MpegEncContext *s, int16_t block[12][64],
>                     || s->avctx->skip_idct >= AVDISCARD_ALL)
>                      goto skip_idct;
>              }
> +            }
>  
>              /* add dct residue */
>              if (IS_ENCODER(s) || !(IS_MPEG12(s) || s->msmpeg4_version

Will apply this patchset tomorrow unless there are objections.

- Andreas
diff mbox series

Patch

diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c
index 5095149eaa..448b65bb96 100644
--- a/libavcodec/mpegvideo.c
+++ b/libavcodec/mpegvideo.c
@@ -1413,7 +1413,6 @@  void mpv_reconstruct_mb_internal(MpegEncContext *s, int16_t block[12][64],
                         ff_mpv_motion(s, dest_y, dest_cb, dest_cr, 1, s->next_picture.f->data, op_pix, op_qpix);
                     }
                 }
-            }
 
             /* skip dequant / idct if we are really late ;) */
             if(s->avctx->skip_idct){
@@ -1422,6 +1421,7 @@  void mpv_reconstruct_mb_internal(MpegEncContext *s, int16_t block[12][64],
                    || s->avctx->skip_idct >= AVDISCARD_ALL)
                     goto skip_idct;
             }
+            }
 
             /* add dct residue */
             if (IS_ENCODER(s) || !(IS_MPEG12(s) || s->msmpeg4_version