diff mbox series

[FFmpeg-devel] vvcdec: add TODO for combining transform, lmcs_scale_chroma, and add_residual

Message ID TYSPR06MB643370FD131D1F0B5312B3DEAA60A@TYSPR06MB6433.apcprd06.prod.outlook.com
State Accepted
Commit 02d600c568d14a201c776712bc5775e17c59078a
Headers show
Series [FFmpeg-devel] vvcdec: add TODO for combining transform, lmcs_scale_chroma, and add_residual | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Nuo Mi Jan. 3, 2024, 3:52 p.m. UTC 
Thanks for the suggestion from Lynne.
---
 libavcodec/vvc/vvc_intra.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Lynne Jan. 6, 2024, 8:03 p.m. UTC | #1 
Jan 3, 2024, 16:53 by nuomi2021@gmail.com:

> Thanks for the suggestion from Lynne.
> ---
>  libavcodec/vvc/vvc_intra.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/libavcodec/vvc/vvc_intra.c b/libavcodec/vvc/vvc_intra.c
> index 43de312a71..214ad38c8c 100644
> --- a/libavcodec/vvc/vvc_intra.c
> +++ b/libavcodec/vvc/vvc_intra.c
> @@ -552,6 +552,8 @@ static void itransform(VVCLocalContext *lc, TransformUnit *tu, const int tu_idx,
>  
>  if (chroma_scale)
>  fc->vvcdsp.intra.lmcs_scale_chroma(lc, temp, tb->coeffs, w, h, cu->x0, cu->y0);
> +            // TODO: Address performance issue here by combining transform, lmcs_scale_chroma, and add_residual into one function.
> +            // Complete this task before implementing ASM code.
>  fc->vvcdsp.itx.add_residual(dst, chroma_scale ? temp : tb->coeffs, w, h, stride);
>  
>  if (tu->joint_cbcr_residual_flag && tb->c_idx)
>

LGTM
Nuo Mi Jan. 7, 2024, 1:11 a.m. UTC | #2 
On Sun, Jan 7, 2024 at 4:03 AM Lynne <dev@lynne.ee> wrote:

> Jan 3, 2024, 16:53 by nuomi2021@gmail.com:
>
> > Thanks for the suggestion from Lynne.
> > ---
> >  libavcodec/vvc/vvc_intra.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/libavcodec/vvc/vvc_intra.c b/libavcodec/vvc/vvc_intra.c
> > index 43de312a71..214ad38c8c 100644
> > --- a/libavcodec/vvc/vvc_intra.c
> > +++ b/libavcodec/vvc/vvc_intra.c
> > @@ -552,6 +552,8 @@ static void itransform(VVCLocalContext *lc,
> TransformUnit *tu, const int tu_idx,
> >
> >  if (chroma_scale)
> >  fc->vvcdsp.intra.lmcs_scale_chroma(lc, temp, tb->coeffs, w, h, cu->x0,
> cu->y0);
> > +            // TODO: Address performance issue here by combining
> transform, lmcs_scale_chroma, and add_residual into one function.
> > +            // Complete this task before implementing ASM code.
> >  fc->vvcdsp.itx.add_residual(dst, chroma_scale ? temp : tb->coeffs, w,
> h, stride);
> >
> >  if (tu->joint_cbcr_residual_flag && tb->c_idx)
> >
>
> LGTM
>
Thank you, Lynne.
Pushed

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
diff mbox series

Patch

diff --git a/libavcodec/vvc/vvc_intra.c b/libavcodec/vvc/vvc_intra.c
index 43de312a71..214ad38c8c 100644
--- a/libavcodec/vvc/vvc_intra.c
+++ b/libavcodec/vvc/vvc_intra.c
@@ -552,6 +552,8 @@  static void itransform(VVCLocalContext *lc, TransformUnit *tu, const int tu_idx,
 
             if (chroma_scale)
                 fc->vvcdsp.intra.lmcs_scale_chroma(lc, temp, tb->coeffs, w, h, cu->x0, cu->y0);
+            // TODO: Address performance issue here by combining transform, lmcs_scale_chroma, and add_residual into one function.
+            // Complete this task before implementing ASM code.
             fc->vvcdsp.itx.add_residual(dst, chroma_scale ? temp : tb->coeffs, w, h, stride);
 
             if (tu->joint_cbcr_residual_flag && tb->c_idx)