diff mbox series

[FFmpeg-devel,30/38] avfilter/vf_hflip: Remove empty options and AVClass

Message ID AM7PR03MB66601D3FC87BB85716AD58728FD89@AM7PR03MB6660.eurprd03.prod.outlook.com
State New
Headers show
Series [FFmpeg-devel,01/39] avfilter/vf_maskedminmax: Simplify init | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 fail Make fate failed
andriy/make_ppc success Make finished
andriy/make_fate_ppc fail Make fate failed

Commit Message

Andreas Rheinhardt Sept. 12, 2021, 10:53 a.m. UTC 
This filter only had an AVClass and empty options because up until
recently, avfilter_init_str() errored out when options were provided
for a filter without an AVClass. But setting (generic) options is
necessary to take advantage of timeline support. So with
avfilter_init_str() fixed, the AVClass and the options can be removed.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavfilter/hflip.h    | 1 -
 libavfilter/vf_hflip.c | 8 --------
 2 files changed, 9 deletions(-)

Comments

Paul B Mahol Sept. 13, 2021, 11:56 a.m. UTC | #1 
lgtm
diff mbox series

Patch

diff --git a/libavfilter/hflip.h b/libavfilter/hflip.h
index a40b98470b..956eb982a1 100644
--- a/libavfilter/hflip.h
+++ b/libavfilter/hflip.h
@@ -25,7 +25,6 @@ 
 #include "avfilter.h"
 
 typedef struct FlipContext {
-    const AVClass *class;
     int max_step[4];    ///< max pixel step for each plane, expressed as a number of bytes
     int bayer_plus1;    ///< 1 .. not a Bayer input format, 2 .. Bayer input format
     int planewidth[4];  ///< width of each plane
diff --git a/libavfilter/vf_hflip.c b/libavfilter/vf_hflip.c
index 7b5650a821..bdff052b45 100644
--- a/libavfilter/vf_hflip.c
+++ b/libavfilter/vf_hflip.c
@@ -26,7 +26,6 @@ 
 
 #include <string.h>
 
-#include "libavutil/opt.h"
 #include "avfilter.h"
 #include "formats.h"
 #include "hflip.h"
@@ -37,12 +36,6 @@ 
 #include "libavutil/intreadwrite.h"
 #include "libavutil/imgutils.h"
 
-static const AVOption hflip_options[] = {
-    { NULL }
-};
-
-AVFILTER_DEFINE_CLASS(hflip);
-
 static int query_formats(AVFilterContext *ctx)
 {
     AVFilterFormats *pix_fmts = NULL;
@@ -248,7 +241,6 @@  const AVFilter ff_vf_hflip = {
     .name          = "hflip",
     .description   = NULL_IF_CONFIG_SMALL("Horizontally flip the input video."),
     .priv_size     = sizeof(FlipContext),
-    .priv_class    = &hflip_class,
     .query_formats = query_formats,
     FILTER_INPUTS(avfilter_vf_hflip_inputs),
     FILTER_OUTPUTS(avfilter_vf_hflip_outputs),