diff mbox series

[FFmpeg-devel] avformat/movenc: Fix invalid check

Message ID DB6PR0101MB221424757E5449EE15EBC17F8FBA9@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com
State Accepted
Commit e4be88704f617c8fccf87068037726debb56985e
Headers show
Series [FFmpeg-devel] avformat/movenc: Fix invalid check | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished
andriy/make_armv7_RPi4 success Make finished
andriy/make_fate_armv7_RPi4 success Make fate finished

Commit Message

Andreas Rheinhardt June 30, 2022, 8:14 p.m. UTC 
Regression since c9de096851803d45444ae9dfe3a390a2d53ac71b.
Fixes Coverity ID 1506839.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavformat/movenc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jan Ekström June 30, 2022, 8:18 p.m. UTC | #1 
On Thu, Jun 30, 2022 at 11:15 PM Andreas Rheinhardt
<andreas.rheinhardt@outlook.com> wrote:
>
> Regression since c9de096851803d45444ae9dfe3a390a2d53ac71b.
> Fixes Coverity ID 1506839.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavformat/movenc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> index 0ef6b3c76e..a4dace7c1d 100644
> --- a/libavformat/movenc.c
> +++ b/libavformat/movenc.c
> @@ -424,7 +424,7 @@ static int handle_eac3(MOVMuxContext *mov, AVPacket *pkt, MOVTrack *track)
>      if (!info->pkt && !(info->pkt = av_packet_alloc()))
>          return AVERROR(ENOMEM);
>
> -    if ((ret = avpriv_ac3_parse_header(&hdr, pkt->data, pkt->size) < 0)) {
> +    if ((ret = avpriv_ac3_parse_header(&hdr, pkt->data, pkt->size)) < 0) {

Geez. Sorry for missing this and thanks for noticing it.

LGTM.

Jan
diff mbox series

Patch

diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index 0ef6b3c76e..a4dace7c1d 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
@@ -424,7 +424,7 @@  static int handle_eac3(MOVMuxContext *mov, AVPacket *pkt, MOVTrack *track)
     if (!info->pkt && !(info->pkt = av_packet_alloc()))
         return AVERROR(ENOMEM);
 
-    if ((ret = avpriv_ac3_parse_header(&hdr, pkt->data, pkt->size) < 0)) {
+    if ((ret = avpriv_ac3_parse_header(&hdr, pkt->data, pkt->size)) < 0) {
         if (ret == AVERROR(ENOMEM))
             goto end;