| Message ID | 20230618215021.3044-6-michael@niedermayer.cc |
|---|---|
| State | Accepted |
| Commit | 3323b515abc1cda20510e5e5d7ae4f3d7419ec8e |
| Headers | show |
| Series | [FFmpeg-devel,1/6] avformat/jpegxl_anim_dec: Perform operations in a different order | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
On Sun, 18 Jun 2023, at 23:50, Michael Niedermayer wrote: > doc/developer.texi | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) +1
Quoting Michael Niedermayer (2023-06-18 23:50:21) > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> > --- > doc/developer.texi | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/doc/developer.texi b/doc/developer.texi > index a7da2ce2d5..0c2f2cd7d1 100644 > --- a/doc/developer.texi > +++ b/doc/developer.texi > @@ -805,7 +805,10 @@ Lines with similar content should be aligned vertically when doing so > improves readability. > > @item > -Consider adding a regression test for your code. > +Consider adding a regression test for your code. All new modules > +should be covered by tests. That includes demuxers, muxers, decoders, encoders s/should/must/?
NAK
Quoting Paul B Mahol (2023-06-19 18:09:06)
> NAK
You like throwing this letter sequence around, but without some actual
arguments it's meaningless and will be ignored.
On Sun, Jun 18, 2023 at 11:50:21PM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> > --- > doc/developer.texi | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) will apply [...]
diff --git a/doc/developer.texi b/doc/developer.texi index a7da2ce2d5..0c2f2cd7d1 100644 --- a/doc/developer.texi +++ b/doc/developer.texi @@ -805,7 +805,10 @@ Lines with similar content should be aligned vertically when doing so improves readability. @item -Consider adding a regression test for your code. +Consider adding a regression test for your code. All new modules +should be covered by tests. That includes demuxers, muxers, decoders, encoders +filters, bitstream filters, parsers. If its not possible to do that, add +an explanation why to your patchset, its ok to not test if theres a reason. @item If you added YASM code please check that things still work with --disable-yasm.
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> --- doc/developer.texi | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)